kitos
394d5d9056
Enable ANN rules in ruff.toml (flake8-annotations) and resolve all 221 violations: ANN201/ANN202 — return types on 168 public/private functions: - All 28 FastAPI routers: endpoints annotated with dict/list/specific schema/ StreamingResponse/FileResponse/JSONResponse as appropriate - main.py: lifespan→AsyncGenerator[None,None], exception handlers→JSONResponse - database.py: get_db→Generator[Session,None,None], proxy methods→correct types - middleware/request_context.py: dispatch→Response with Callable call_next type ANN001/ANN002/ANN003 — 32 missing argument types: - seed_demo.py: all db parameters typed as Session - domain/unit_of_work.py: __aexit__ exc_type/exc_val/exc_tb typed with TracebackType - services: audit_service user_id→UUID|None, heatmap_service query/model/builder, notification_service test→Test, tempo_service test→Test/user→User, test_workflow_service test_id→UUID, campaign_crud **fields→object, test_crud **fields→object (4 sites) ANN401 — 16 Any usages resolved: - Domain entities (campaign/technique/threat_actor/test_entity): replaced Any with actual ORM types via TYPE_CHECKING guards to avoid circular imports - detection_rule_service: test_id/detection_rule_id/evaluator_id→UUID - score_cache: kept Any with # noqa: ANN401 (genuinely generic cache) - jira_service/tempo_service: kept Any with # noqa: ANN401 (lazy optional deps) - d3fend_import_service: _to_str(v: Any) kept with # noqa: ANN401 ANN204/ANN205/ANN206 — special/static/class methods: - database.py proxy __call__/__getattr__: *args: object/**kwargs: object - schemas/test.py model_validate: obj→object, **kwargs→object - sa_technique_repository._int_type→type All 439 unit tests pass. ruff check app/ → All checks passed! Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
24 lines
948 B
TOML
24 lines
948 B
TOML
# PEP8 line length: 120 chars — the codebase uses longer identifiers and SQLAlchemy chaining
|
|
line-length = 120
|
|
|
|
[lint]
|
|
# PEP8 compliance rules enforced:
|
|
# E/W — pycodestyle (core PEP8 style and warnings)
|
|
# F — pyflakes (unused imports, undefined names)
|
|
# I — isort (import ordering per PEP8 convention)
|
|
# N — pep8-naming (class/function/variable naming conventions)
|
|
# ANN — flake8-annotations (type hint enforcement)
|
|
select = ["E", "W", "F", "I", "N", "ANN"]
|
|
|
|
ignore = [
|
|
# SQLAlchemy filter syntax requires `== True` / `== False` comparisons
|
|
"E712",
|
|
# ANN101/ANN102 (self/cls type annotations) removed from ruff — not needed
|
|
]
|
|
|
|
[lint.per-file-ignores]
|
|
# Tests use broad exception catching and unusual import patterns
|
|
"tests/**" = ["E", "F", "N"]
|
|
# Data file: D3FEND technique descriptions contain URLs and long strings that cannot be meaningfully wrapped
|
|
"app/services/d3fend_import_service.py" = ["E501"]
|