kitos
9ff0f04ba3
Enable ANN rules in ruff.toml (flake8-annotations) and resolve all 221 violations: ANN201/ANN202 — return types on 168 public/private functions: - All 28 FastAPI routers: endpoints annotated with dict/list/specific schema/ StreamingResponse/FileResponse/JSONResponse as appropriate - main.py: lifespan→AsyncGenerator[None,None], exception handlers→JSONResponse - database.py: get_db→Generator[Session,None,None], proxy methods→correct types - middleware/request_context.py: dispatch→Response with Callable call_next type ANN001/ANN002/ANN003 — 32 missing argument types: - seed_demo.py: all db parameters typed as Session - domain/unit_of_work.py: __aexit__ exc_type/exc_val/exc_tb typed with TracebackType - services: audit_service user_id→UUID|None, heatmap_service query/model/builder, notification_service test→Test, tempo_service test→Test/user→User, test_workflow_service test_id→UUID, campaign_crud **fields→object, test_crud **fields→object (4 sites) ANN401 — 16 Any usages resolved: - Domain entities (campaign/technique/threat_actor/test_entity): replaced Any with actual ORM types via TYPE_CHECKING guards to avoid circular imports - detection_rule_service: test_id/detection_rule_id/evaluator_id→UUID - score_cache: kept Any with # noqa: ANN401 (genuinely generic cache) - jira_service/tempo_service: kept Any with # noqa: ANN401 (lazy optional deps) - d3fend_import_service: _to_str(v: Any) kept with # noqa: ANN401 ANN204/ANN205/ANN206 — special/static/class methods: - database.py proxy __call__/__getattr__: *args: object/**kwargs: object - schemas/test.py model_validate: obj→object, **kwargs→object - sa_technique_repository._int_type→type All 439 unit tests pass. ruff check app/ → All checks passed!
95 lines
3.2 KiB
Python
95 lines
3.2 KiB
Python
"""Notification endpoints.
|
|
|
|
Endpoints
|
|
---------
|
|
GET /notifications — list user notifications (paginated)
|
|
GET /notifications/unread-count — count of unread notifications
|
|
PATCH /notifications/{id}/read — mark one notification as read
|
|
POST /notifications/read-all — mark all as read
|
|
"""
|
|
|
|
import uuid
|
|
|
|
from fastapi import APIRouter, Depends, Query
|
|
from sqlalchemy.orm import Session
|
|
|
|
from app.database import get_db
|
|
from app.dependencies.auth import get_current_user
|
|
from app.domain.unit_of_work import UnitOfWork
|
|
from app.models.user import User
|
|
from app.schemas.notification import NotificationOut, UnreadCountOut
|
|
from app.services.notification_service import (
|
|
get_unread_count,
|
|
list_notifications,
|
|
mark_all_as_read,
|
|
mark_as_read,
|
|
)
|
|
|
|
router = APIRouter(prefix="/notifications", tags=["notifications"])
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# GET /notifications — list (paginated)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
@router.get("", response_model=list[NotificationOut])
|
|
def list_notifications_endpoint(
|
|
offset: int = Query(0, ge=0),
|
|
limit: int = Query(20, ge=1, le=100),
|
|
db: Session = Depends(get_db),
|
|
current_user: User = Depends(get_current_user),
|
|
) -> list[NotificationOut]:
|
|
"""Return paginated notifications for the current user, newest first."""
|
|
return list_notifications(db, current_user.id, offset=offset, limit=limit)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# GET /notifications/unread-count
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
@router.get("/unread-count", response_model=UnreadCountOut)
|
|
def unread_count(
|
|
db: Session = Depends(get_db),
|
|
current_user: User = Depends(get_current_user),
|
|
) -> UnreadCountOut:
|
|
"""Return the number of unread notifications for the current user."""
|
|
count = get_unread_count(db, current_user.id)
|
|
return UnreadCountOut(unread_count=count)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# PATCH /notifications/{id}/read
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
@router.patch("/{notification_id}/read", response_model=NotificationOut)
|
|
def read_notification(
|
|
notification_id: uuid.UUID,
|
|
db: Session = Depends(get_db),
|
|
current_user: User = Depends(get_current_user),
|
|
) -> NotificationOut:
|
|
"""Mark a single notification as read."""
|
|
with UnitOfWork(db) as uow:
|
|
notif = mark_as_read(db, notification_id, current_user.id)
|
|
uow.commit()
|
|
return notif
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# POST /notifications/read-all
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
@router.post("/read-all")
|
|
def read_all_notifications(
|
|
db: Session = Depends(get_db),
|
|
current_user: User = Depends(get_current_user),
|
|
) -> dict:
|
|
"""Mark all notifications for the current user as read."""
|
|
with UnitOfWork(db) as uow:
|
|
count = mark_all_as_read(db, current_user.id)
|
|
uow.commit()
|
|
return {"detail": f"Marked {count} notifications as read"}
|