kitos
8f98bdd273
- ruff.toml: select E/W/F/I/N rules, line-length=120, drop legacy ignores - Auto-fix: sort 82 import blocks (isort), remove 29 unused imports, strip 6 trailing-whitespace blank lines in docstrings - main.py: move setup_logging and settings imports to top (E402) - errors.py: noqa N818 on DDD exception names (96 call sites, safe) - intel_service.py: noqa N817 for universal ET alias - atomic/elastic/sigma import services: move _MAX_UNCOMPRESSED_SIZE and _MAX_ENTRIES to module level (N806) - compliance_import_service.py: move SAMPLE_CONTROLS / CIS_CONTROLS to module level; wrap long description strings (N806 + E501) - snapshot_service.py: move STATUS_ORDER dict to module level (N806) - sigma_import_service.py: remove dead dedup_key expression (F841) - threat_actor_import_service.py: remove dead stix_to_actor expression (F841) - data_source.py, seed_demo.py, campaign_scheduler_service.py, lolbas_import_service.py: wrap lines exceeding 120 chars (E501) - d3fend_import_service.py: per-file E501 ignore (data file with long strings) All 439 unit tests pass. ruff check app/ → All checks passed!
97 lines
3.5 KiB
Python
97 lines
3.5 KiB
Python
"""Canonical domain error hierarchy for Aegis.
|
|
|
|
Every service-layer error should be a subclass of :class:`DomainError`.
|
|
The global exception handler in ``app.middleware.error_handler`` maps
|
|
each concrete subclass to an appropriate HTTP status code so that
|
|
services never depend on FastAPI.
|
|
|
|
Existing code that imports from ``app.domain.exceptions`` continues to
|
|
work — that module re-exports everything defined here.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
|
|
class DomainError(Exception):
|
|
"""Base for all domain errors."""
|
|
|
|
def __init__(self, message: str, *, code: str = "DOMAIN_ERROR") -> None:
|
|
self.message = message
|
|
self.code = code
|
|
super().__init__(message)
|
|
|
|
|
|
# ── Entity lifecycle ──────────────────────────────────────────────────
|
|
|
|
|
|
class EntityNotFoundError(DomainError):
|
|
"""A requested entity does not exist."""
|
|
|
|
def __init__(self, entity: str, identifier: str) -> None:
|
|
super().__init__(f"{entity} not found: {identifier}", code="NOT_FOUND")
|
|
self.entity = entity
|
|
self.identifier = identifier
|
|
|
|
|
|
class DuplicateEntityError(DomainError):
|
|
"""Creating an entity that already exists."""
|
|
|
|
def __init__(self, entity: str, field: str, value: str) -> None:
|
|
super().__init__(
|
|
f"{entity} with {field}='{value}' already exists",
|
|
code="DUPLICATE",
|
|
)
|
|
|
|
|
|
# ── State machine ────────────────────────────────────────────────────
|
|
|
|
|
|
class InvalidStateTransition(DomainError): # noqa: N818 — DDD term, renaming would break 96 call sites
|
|
"""A state-machine transition is not allowed."""
|
|
|
|
def __init__(
|
|
self,
|
|
current_state: str,
|
|
target_state: str,
|
|
valid_transitions: list[str] | None = None,
|
|
) -> None:
|
|
msg = f"Cannot transition from '{current_state}' to '{target_state}'"
|
|
if valid_transitions:
|
|
msg += f". Valid transitions: {valid_transitions}"
|
|
super().__init__(msg, code="INVALID_TRANSITION")
|
|
self.current_state = current_state
|
|
self.target_state = target_state
|
|
self.valid_transitions = valid_transitions or []
|
|
|
|
|
|
# ── Business rules ────────────────────────────────────────────────────
|
|
|
|
|
|
class BusinessRuleViolation(DomainError): # noqa: N818 — DDD term, renaming would break 96 call sites
|
|
"""An operation violates a business invariant."""
|
|
|
|
def __init__(self, message: str) -> None:
|
|
super().__init__(message, code="BUSINESS_RULE_VIOLATION")
|
|
|
|
|
|
class InvalidOperationError(BusinessRuleViolation):
|
|
"""An operation is invalid in the current context.
|
|
|
|
Kept for backward compatibility; new code should prefer
|
|
:class:`BusinessRuleViolation` directly.
|
|
"""
|
|
|
|
def __init__(self, message: str) -> None:
|
|
super().__init__(message)
|
|
self.code = "INVALID_OPERATION"
|
|
|
|
|
|
# ── Authorization ────────────────────────────────────────────────────
|
|
|
|
|
|
class PermissionViolation(DomainError): # noqa: N818 — DDD term, renaming would break 96 call sites
|
|
"""The user lacks permissions for an action."""
|
|
|
|
def __init__(self, message: str = "Insufficient permissions") -> None:
|
|
super().__init__(message, code="FORBIDDEN")
|