kitos
394d5d9056
Enable ANN rules in ruff.toml (flake8-annotations) and resolve all 221 violations: ANN201/ANN202 — return types on 168 public/private functions: - All 28 FastAPI routers: endpoints annotated with dict/list/specific schema/ StreamingResponse/FileResponse/JSONResponse as appropriate - main.py: lifespan→AsyncGenerator[None,None], exception handlers→JSONResponse - database.py: get_db→Generator[Session,None,None], proxy methods→correct types - middleware/request_context.py: dispatch→Response with Callable call_next type ANN001/ANN002/ANN003 — 32 missing argument types: - seed_demo.py: all db parameters typed as Session - domain/unit_of_work.py: __aexit__ exc_type/exc_val/exc_tb typed with TracebackType - services: audit_service user_id→UUID|None, heatmap_service query/model/builder, notification_service test→Test, tempo_service test→Test/user→User, test_workflow_service test_id→UUID, campaign_crud **fields→object, test_crud **fields→object (4 sites) ANN401 — 16 Any usages resolved: - Domain entities (campaign/technique/threat_actor/test_entity): replaced Any with actual ORM types via TYPE_CHECKING guards to avoid circular imports - detection_rule_service: test_id/detection_rule_id/evaluator_id→UUID - score_cache: kept Any with # noqa: ANN401 (genuinely generic cache) - jira_service/tempo_service: kept Any with # noqa: ANN401 (lazy optional deps) - d3fend_import_service: _to_str(v: Any) kept with # noqa: ANN401 ANN204/ANN205/ANN206 — special/static/class methods: - database.py proxy __call__/__getattr__: *args: object/**kwargs: object - schemas/test.py model_validate: obj→object, **kwargs→object - sa_technique_repository._int_type→type All 439 unit tests pass. ruff check app/ → All checks passed! Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
51 lines
1.6 KiB
Python
51 lines
1.6 KiB
Python
"""Advanced metrics endpoints — coverage by tactic, never-tested, avg validation time."""
|
|
|
|
from fastapi import APIRouter, Depends
|
|
from sqlalchemy.orm import Session
|
|
|
|
from app.database import get_db
|
|
from app.dependencies.auth import get_current_user
|
|
from app.models.user import User
|
|
from app.services import advanced_metrics_service
|
|
|
|
router = APIRouter(prefix="/metrics/advanced", tags=["advanced-metrics"])
|
|
|
|
|
|
@router.get("/coverage-by-tactic")
|
|
def coverage_by_tactic(
|
|
db: Session = Depends(get_db),
|
|
user: User = Depends(get_current_user),
|
|
) -> list:
|
|
"""Coverage percentage broken down by MITRE ATT&CK tactic."""
|
|
return advanced_metrics_service.get_coverage_by_tactic(db)
|
|
|
|
|
|
@router.get("/never-tested")
|
|
def never_tested_techniques(
|
|
db: Session = Depends(get_db),
|
|
user: User = Depends(get_current_user),
|
|
) -> list:
|
|
"""Techniques that have never had a test created."""
|
|
return advanced_metrics_service.get_never_tested_techniques(db)
|
|
|
|
|
|
@router.get("/avg-validation-time")
|
|
def avg_validation_time(
|
|
db: Session = Depends(get_db),
|
|
user: User = Depends(get_current_user),
|
|
) -> dict:
|
|
"""Average time from test creation to validation, computed from audit logs.
|
|
|
|
Returns overall average and per-phase averages where data is available.
|
|
"""
|
|
return advanced_metrics_service.get_avg_validation_time(db)
|
|
|
|
|
|
@router.get("/detection-rate-trend")
|
|
def detection_rate_trend(
|
|
db: Session = Depends(get_db),
|
|
user: User = Depends(get_current_user),
|
|
) -> list:
|
|
"""Monthly detection rate trend for the last 12 months."""
|
|
return advanced_metrics_service.get_detection_rate_trend(db)
|