kitos
394d5d9056
Enable ANN rules in ruff.toml (flake8-annotations) and resolve all 221 violations: ANN201/ANN202 — return types on 168 public/private functions: - All 28 FastAPI routers: endpoints annotated with dict/list/specific schema/ StreamingResponse/FileResponse/JSONResponse as appropriate - main.py: lifespan→AsyncGenerator[None,None], exception handlers→JSONResponse - database.py: get_db→Generator[Session,None,None], proxy methods→correct types - middleware/request_context.py: dispatch→Response with Callable call_next type ANN001/ANN002/ANN003 — 32 missing argument types: - seed_demo.py: all db parameters typed as Session - domain/unit_of_work.py: __aexit__ exc_type/exc_val/exc_tb typed with TracebackType - services: audit_service user_id→UUID|None, heatmap_service query/model/builder, notification_service test→Test, tempo_service test→Test/user→User, test_workflow_service test_id→UUID, campaign_crud **fields→object, test_crud **fields→object (4 sites) ANN401 — 16 Any usages resolved: - Domain entities (campaign/technique/threat_actor/test_entity): replaced Any with actual ORM types via TYPE_CHECKING guards to avoid circular imports - detection_rule_service: test_id/detection_rule_id/evaluator_id→UUID - score_cache: kept Any with # noqa: ANN401 (genuinely generic cache) - jira_service/tempo_service: kept Any with # noqa: ANN401 (lazy optional deps) - d3fend_import_service: _to_str(v: Any) kept with # noqa: ANN401 ANN204/ANN205/ANN206 — special/static/class methods: - database.py proxy __call__/__getattr__: *args: object/**kwargs: object - schemas/test.py model_validate: obj→object, **kwargs→object - sa_technique_repository._int_type→type All 439 unit tests pass. ruff check app/ → All checks passed! Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
100 lines
3.2 KiB
Python
100 lines
3.2 KiB
Python
"""Threat actor domain entity with coverage analysis logic.
|
|
|
|
Pure domain logic — no framework imports.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import uuid
|
|
from dataclasses import dataclass, field
|
|
from typing import TYPE_CHECKING
|
|
|
|
if TYPE_CHECKING:
|
|
from app.models.threat_actor import ThreatActor as ThreatActorORM
|
|
|
|
|
|
@dataclass
|
|
class ThreatActorTechniqueRef:
|
|
"""Lightweight reference to a technique used by an actor."""
|
|
|
|
technique_id: uuid.UUID
|
|
mitre_id: str | None = None
|
|
name: str | None = None
|
|
status: str | None = None
|
|
usage_description: str | None = None
|
|
|
|
|
|
@dataclass
|
|
class ThreatActorEntity:
|
|
name: str
|
|
id: uuid.UUID | None = None
|
|
mitre_id: str | None = None
|
|
aliases: list[str] = field(default_factory=list)
|
|
description: str | None = None
|
|
country: str | None = None
|
|
target_sectors: list[str] = field(default_factory=list)
|
|
target_regions: list[str] = field(default_factory=list)
|
|
motivation: str | None = None
|
|
sophistication: str | None = None
|
|
first_seen: str | None = None
|
|
last_seen: str | None = None
|
|
is_active: bool = True
|
|
techniques: list[ThreatActorTechniqueRef] = field(default_factory=list)
|
|
|
|
@property
|
|
def technique_count(self) -> int:
|
|
return len(self.techniques)
|
|
|
|
@property
|
|
def covered_techniques(self) -> list[ThreatActorTechniqueRef]:
|
|
return [
|
|
t for t in self.techniques
|
|
if t.status in ("validated", "partial")
|
|
]
|
|
|
|
@property
|
|
def uncovered_techniques(self) -> list[ThreatActorTechniqueRef]:
|
|
return [
|
|
t for t in self.techniques
|
|
if t.status not in ("validated", "partial")
|
|
]
|
|
|
|
@property
|
|
def coverage_pct(self) -> float:
|
|
if not self.techniques:
|
|
return 0.0
|
|
return round(len(self.covered_techniques) / len(self.techniques) * 100, 1)
|
|
|
|
@classmethod
|
|
def from_orm(cls, orm: ThreatActorORM) -> ThreatActorEntity:
|
|
techs: list[ThreatActorTechniqueRef] = []
|
|
for tat in getattr(orm, "techniques", None) or []:
|
|
technique = getattr(tat, "technique", None)
|
|
techs.append(ThreatActorTechniqueRef(
|
|
technique_id=tat.technique_id,
|
|
mitre_id=getattr(technique, "mitre_id", None) if technique else None,
|
|
name=getattr(technique, "name", None) if technique else None,
|
|
status=(
|
|
technique.status_global.value
|
|
if technique and hasattr(technique.status_global, "value")
|
|
else getattr(technique, "status_global", None) if technique else None
|
|
),
|
|
usage_description=tat.usage_description,
|
|
))
|
|
return cls(
|
|
id=orm.id,
|
|
name=orm.name,
|
|
mitre_id=orm.mitre_id,
|
|
aliases=orm.aliases or [],
|
|
description=orm.description,
|
|
country=orm.country,
|
|
target_sectors=orm.target_sectors or [],
|
|
target_regions=orm.target_regions or [],
|
|
motivation=orm.motivation,
|
|
sophistication=orm.sophistication,
|
|
first_seen=orm.first_seen,
|
|
last_seen=orm.last_seen,
|
|
is_active=orm.is_active if orm.is_active is not None else True,
|
|
techniques=techs,
|
|
)
|