Some checks failed
Aegis CI / lint-and-test (push) Has been cancelled
- Add UnitOfWork context manager in domain/unit_of_work.py with commit/rollback/flush API and auto-rollback on exception - Remove all db.commit() from test_workflow_service (8 calls), notification_service (4 calls), status_service (1 call) - Services now only stage changes via db.add/db.flush; caller owns the transaction boundary - Update routers/tests.py: wrap 9 workflow endpoints in UnitOfWork context managers - Update routers/notifications.py: wrap mark_as_read and mark_all_as_read in UnitOfWork
109 lines
3.5 KiB
Python
109 lines
3.5 KiB
Python
"""Notification endpoints.
|
|
|
|
Endpoints
|
|
---------
|
|
GET /notifications — list user notifications (paginated)
|
|
GET /notifications/unread-count — count of unread notifications
|
|
PATCH /notifications/{id}/read — mark one notification as read
|
|
POST /notifications/read-all — mark all as read
|
|
"""
|
|
|
|
import uuid
|
|
|
|
from fastapi import APIRouter, Depends, HTTPException, Query, status
|
|
from sqlalchemy.orm import Session
|
|
|
|
from app.database import get_db
|
|
from app.dependencies.auth import get_current_user
|
|
from app.domain.unit_of_work import UnitOfWork
|
|
from app.models.notification import Notification
|
|
from app.models.user import User
|
|
from app.schemas.notification import NotificationOut, UnreadCountOut
|
|
from app.services.notification_service import (
|
|
mark_as_read,
|
|
mark_all_as_read,
|
|
get_unread_count,
|
|
)
|
|
|
|
router = APIRouter(prefix="/notifications", tags=["notifications"])
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# GET /notifications — list (paginated)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
@router.get("", response_model=list[NotificationOut])
|
|
def list_notifications(
|
|
offset: int = Query(0, ge=0),
|
|
limit: int = Query(20, ge=1, le=100),
|
|
db: Session = Depends(get_db),
|
|
current_user: User = Depends(get_current_user),
|
|
):
|
|
"""Return paginated notifications for the current user, newest first."""
|
|
notifs = (
|
|
db.query(Notification)
|
|
.filter(Notification.user_id == current_user.id)
|
|
.order_by(Notification.created_at.desc())
|
|
.offset(offset)
|
|
.limit(limit)
|
|
.all()
|
|
)
|
|
return notifs
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# GET /notifications/unread-count
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
@router.get("/unread-count", response_model=UnreadCountOut)
|
|
def unread_count(
|
|
db: Session = Depends(get_db),
|
|
current_user: User = Depends(get_current_user),
|
|
):
|
|
"""Return the number of unread notifications for the current user."""
|
|
count = get_unread_count(db, current_user.id)
|
|
return UnreadCountOut(unread_count=count)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# PATCH /notifications/{id}/read
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
@router.patch("/{notification_id}/read", response_model=NotificationOut)
|
|
def read_notification(
|
|
notification_id: uuid.UUID,
|
|
db: Session = Depends(get_db),
|
|
current_user: User = Depends(get_current_user),
|
|
):
|
|
"""Mark a single notification as read."""
|
|
with UnitOfWork(db) as uow:
|
|
success = mark_as_read(db, notification_id, current_user.id)
|
|
if not success:
|
|
raise HTTPException(
|
|
status_code=status.HTTP_404_NOT_FOUND,
|
|
detail="Notification not found",
|
|
)
|
|
uow.commit()
|
|
notif = db.query(Notification).filter(Notification.id == notification_id).first()
|
|
return notif
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# POST /notifications/read-all
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
@router.post("/read-all")
|
|
def read_all_notifications(
|
|
db: Session = Depends(get_db),
|
|
current_user: User = Depends(get_current_user),
|
|
):
|
|
"""Mark all notifications for the current user as read."""
|
|
with UnitOfWork(db) as uow:
|
|
count = mark_all_as_read(db, current_user.id)
|
|
uow.commit()
|
|
return {"detail": f"Marked {count} notifications as read"}
|