kitos
9ff0f04ba3
Enable ANN rules in ruff.toml (flake8-annotations) and resolve all 221 violations: ANN201/ANN202 — return types on 168 public/private functions: - All 28 FastAPI routers: endpoints annotated with dict/list/specific schema/ StreamingResponse/FileResponse/JSONResponse as appropriate - main.py: lifespan→AsyncGenerator[None,None], exception handlers→JSONResponse - database.py: get_db→Generator[Session,None,None], proxy methods→correct types - middleware/request_context.py: dispatch→Response with Callable call_next type ANN001/ANN002/ANN003 — 32 missing argument types: - seed_demo.py: all db parameters typed as Session - domain/unit_of_work.py: __aexit__ exc_type/exc_val/exc_tb typed with TracebackType - services: audit_service user_id→UUID|None, heatmap_service query/model/builder, notification_service test→Test, tempo_service test→Test/user→User, test_workflow_service test_id→UUID, campaign_crud **fields→object, test_crud **fields→object (4 sites) ANN401 — 16 Any usages resolved: - Domain entities (campaign/technique/threat_actor/test_entity): replaced Any with actual ORM types via TYPE_CHECKING guards to avoid circular imports - detection_rule_service: test_id/detection_rule_id/evaluator_id→UUID - score_cache: kept Any with # noqa: ANN401 (genuinely generic cache) - jira_service/tempo_service: kept Any with # noqa: ANN401 (lazy optional deps) - d3fend_import_service: _to_str(v: Any) kept with # noqa: ANN401 ANN204/ANN205/ANN206 — special/static/class methods: - database.py proxy __call__/__getattr__: *args: object/**kwargs: object - schemas/test.py model_validate: obj→object, **kwargs→object - sa_technique_repository._int_type→type All 439 unit tests pass. ruff check app/ → All checks passed!
98 lines
2.6 KiB
Python
98 lines
2.6 KiB
Python
"""Threat actor endpoints.
|
|
|
|
Provides listing, detail, coverage analysis, and gap analysis for
|
|
threat actor profiles imported from MITRE CTI.
|
|
"""
|
|
|
|
import logging
|
|
from typing import Optional
|
|
|
|
from fastapi import APIRouter, Depends, Query
|
|
from sqlalchemy.orm import Session
|
|
|
|
from app.database import get_db
|
|
from app.dependencies.auth import get_current_user
|
|
from app.models.user import User
|
|
from app.services.threat_actor_service import (
|
|
get_actor_coverage,
|
|
get_actor_detail,
|
|
get_actor_gaps,
|
|
list_actors,
|
|
)
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
router = APIRouter(prefix="/threat-actors", tags=["threat-actors"])
|
|
|
|
|
|
@router.get("")
|
|
def list_threat_actors(
|
|
search: Optional[str] = Query(None),
|
|
country: Optional[str] = Query(None),
|
|
motivation: Optional[str] = Query(None),
|
|
sophistication: Optional[str] = Query(None),
|
|
target_sectors: Optional[str] = Query(None),
|
|
offset: int = Query(0, ge=0),
|
|
limit: int = Query(50, ge=1, le=200),
|
|
db: Session = Depends(get_db),
|
|
current_user: User = Depends(get_current_user),
|
|
) -> list:
|
|
"""List threat actors with optional filters and pagination.
|
|
|
|
**Requires** authentication (any role).
|
|
"""
|
|
return list_actors(
|
|
db,
|
|
search=search,
|
|
country=country,
|
|
motivation=motivation,
|
|
sophistication=sophistication,
|
|
target_sectors=target_sectors,
|
|
offset=offset,
|
|
limit=limit,
|
|
)
|
|
|
|
|
|
@router.get("/{actor_id}")
|
|
def get_threat_actor(
|
|
actor_id: str,
|
|
db: Session = Depends(get_db),
|
|
current_user: User = Depends(get_current_user),
|
|
) -> dict:
|
|
"""Get detailed info about a threat actor including techniques.
|
|
|
|
**Requires** authentication (any role).
|
|
"""
|
|
return get_actor_detail(db, actor_id)
|
|
|
|
|
|
@router.get("/{actor_id}/coverage")
|
|
def get_threat_actor_coverage(
|
|
actor_id: str,
|
|
db: Session = Depends(get_db),
|
|
current_user: User = Depends(get_current_user),
|
|
) -> dict:
|
|
"""Calculate coverage percentage against a specific threat actor.
|
|
|
|
**Requires** authentication (any role).
|
|
|
|
Returns the percentage of the actor's techniques that have been
|
|
validated or partially validated, along with a breakdown.
|
|
"""
|
|
return get_actor_coverage(db, actor_id)
|
|
|
|
|
|
@router.get("/{actor_id}/gaps")
|
|
def get_threat_actor_gaps(
|
|
actor_id: str,
|
|
db: Session = Depends(get_db),
|
|
current_user: User = Depends(get_current_user),
|
|
) -> list:
|
|
"""Identify techniques of this actor that are NOT fully validated.
|
|
|
|
**Requires** authentication (any role).
|
|
|
|
Returns list of gap techniques with available templates.
|
|
"""
|
|
return get_actor_gaps(db, actor_id)
|