kitos
9ff0f04ba3
Enable ANN rules in ruff.toml (flake8-annotations) and resolve all 221 violations: ANN201/ANN202 — return types on 168 public/private functions: - All 28 FastAPI routers: endpoints annotated with dict/list/specific schema/ StreamingResponse/FileResponse/JSONResponse as appropriate - main.py: lifespan→AsyncGenerator[None,None], exception handlers→JSONResponse - database.py: get_db→Generator[Session,None,None], proxy methods→correct types - middleware/request_context.py: dispatch→Response with Callable call_next type ANN001/ANN002/ANN003 — 32 missing argument types: - seed_demo.py: all db parameters typed as Session - domain/unit_of_work.py: __aexit__ exc_type/exc_val/exc_tb typed with TracebackType - services: audit_service user_id→UUID|None, heatmap_service query/model/builder, notification_service test→Test, tempo_service test→Test/user→User, test_workflow_service test_id→UUID, campaign_crud **fields→object, test_crud **fields→object (4 sites) ANN401 — 16 Any usages resolved: - Domain entities (campaign/technique/threat_actor/test_entity): replaced Any with actual ORM types via TYPE_CHECKING guards to avoid circular imports - detection_rule_service: test_id/detection_rule_id/evaluator_id→UUID - score_cache: kept Any with # noqa: ANN401 (genuinely generic cache) - jira_service/tempo_service: kept Any with # noqa: ANN401 (lazy optional deps) - d3fend_import_service: _to_str(v: Any) kept with # noqa: ANN401 ANN204/ANN205/ANN206 — special/static/class methods: - database.py proxy __call__/__getattr__: *args: object/**kwargs: object - schemas/test.py model_validate: obj→object, **kwargs→object - sa_technique_repository._int_type→type All 439 unit tests pass. ruff check app/ → All checks passed!
78 lines
2.4 KiB
Python
78 lines
2.4 KiB
Python
"""Audit log viewer router (admin only)."""
|
|
|
|
from datetime import datetime
|
|
from typing import Optional
|
|
|
|
from fastapi import APIRouter, Depends, Query
|
|
from sqlalchemy.orm import Session
|
|
|
|
from app.database import get_db
|
|
from app.dependencies.auth import require_role
|
|
from app.models.user import User
|
|
from app.schemas.audit import AuditLogOut, AuditLogPage
|
|
from app.services.audit_query_service import (
|
|
list_distinct_actions,
|
|
list_distinct_entity_types,
|
|
list_logs,
|
|
)
|
|
|
|
router = APIRouter(prefix="/audit-logs", tags=["audit"])
|
|
|
|
|
|
@router.get("", response_model=AuditLogPage)
|
|
def list_audit_logs(
|
|
user_id: Optional[str] = Query(None, description="Filter by user ID"),
|
|
action: Optional[str] = Query(None, description="Filter by action type"),
|
|
entity_type: Optional[str] = Query(None, description="Filter by entity type"),
|
|
start_date: Optional[datetime] = Query(None, description="Filter by start date"),
|
|
end_date: Optional[datetime] = Query(None, description="Filter by end date"),
|
|
offset: int = Query(0, ge=0, description="Number of records to skip"),
|
|
limit: int = Query(50, ge=1, le=100, description="Max records to return"),
|
|
db: Session = Depends(get_db),
|
|
current_user: User = Depends(require_role("admin")),
|
|
) -> AuditLogPage:
|
|
"""Return paginated audit logs with optional filters.
|
|
|
|
**Requires admin role.**
|
|
"""
|
|
result = list_logs(
|
|
db,
|
|
user_id=user_id,
|
|
action=action,
|
|
entity_type=entity_type,
|
|
start_date=start_date,
|
|
end_date=end_date,
|
|
offset=offset,
|
|
limit=limit,
|
|
)
|
|
return AuditLogPage(
|
|
items=[AuditLogOut(**item) for item in result["items"]],
|
|
total=result["total"],
|
|
offset=result["offset"],
|
|
limit=result["limit"],
|
|
)
|
|
|
|
|
|
@router.get("/actions", response_model=list[str])
|
|
def list_actions(
|
|
db: Session = Depends(get_db),
|
|
current_user: User = Depends(require_role("admin")),
|
|
) -> list[str]:
|
|
"""Return a list of distinct action types in the audit log.
|
|
|
|
**Requires admin role.**
|
|
"""
|
|
return list_distinct_actions(db)
|
|
|
|
|
|
@router.get("/entity-types", response_model=list[str])
|
|
def list_entity_types(
|
|
db: Session = Depends(get_db),
|
|
current_user: User = Depends(require_role("admin")),
|
|
) -> list[str]:
|
|
"""Return a list of distinct entity types in the audit log.
|
|
|
|
**Requires admin role.**
|
|
"""
|
|
return list_distinct_entity_types(db)
|