Kitos
64d64080e0
Critical (1-3): - Replace hardcoded admin credentials with secure auto-generation (seed.py) - Enforce SECRET_KEY configuration, fail in production if missing (config.py) - Add Zip Slip and Zip Bomb protection to all ZIP import services High/Medium (4-9): - Add 50MB file size limit and extension whitelist to evidence uploads - Configure CORS origins via environment variable instead of hardcoded - Migrate JWT storage from localStorage to HttpOnly cookies (frontend+backend) - Add rate limiting (5/min) on login endpoint via slowapi - Replace generic dict payloads with Pydantic schemas (mass assignment) Medium (10-17): - Check is_active on login to prevent disabled users from authenticating - Sanitize exception messages in API responses (system, data_sources) - Escape LIKE wildcards in all ilike search filters across 8 routers - Run Docker container as non-root user (appuser) - Make MINIO_SECURE configurable via environment variable - Add password complexity policy (12+ chars, upper/lower/digit/special) - Implement JWT token revocation via in-memory blacklist + reduce TTL to 15min - Replace xml.etree with defusedxml to prevent Billion Laughs attacks Low (18-20): - Add security headers to Nginx (CSP, X-Frame-Options, HSTS-ready, etc.) - Disable Swagger UI/ReDoc/OpenAPI in production - Restrict /health endpoint to internal networks via Nginx ACL Also: rewrite install.sh as interactive wizard for guided deployment, fix test-from-template validation error (technique_id UUID vs MITRE ID)
60 lines
1.8 KiB
Python
60 lines
1.8 KiB
Python
"""MinIO / S3-compatible object-storage helpers.
|
|
|
|
Provides thin wrappers around boto3 for bucket management, file upload
|
|
and presigned-URL generation.
|
|
"""
|
|
|
|
import boto3
|
|
from botocore.exceptions import ClientError
|
|
|
|
from app.config import settings
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Shared client (module-level singleton)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
_scheme = "https" if settings.MINIO_SECURE else "http"
|
|
|
|
_client = boto3.client(
|
|
"s3",
|
|
endpoint_url=f"{_scheme}://{settings.MINIO_ENDPOINT}",
|
|
aws_access_key_id=settings.MINIO_ACCESS_KEY,
|
|
aws_secret_access_key=settings.MINIO_SECRET_KEY,
|
|
region_name="us-east-1", # MinIO ignores this but boto3 requires it
|
|
)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Public helpers
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def ensure_bucket_exists() -> None:
|
|
"""Create the evidence bucket if it does not already exist."""
|
|
try:
|
|
_client.head_bucket(Bucket=settings.MINIO_BUCKET)
|
|
except ClientError:
|
|
_client.create_bucket(Bucket=settings.MINIO_BUCKET)
|
|
|
|
|
|
def upload_file(content: bytes, key: str) -> str:
|
|
"""Upload *content* to the evidence bucket under *key*.
|
|
|
|
Returns the key that was written (same as the input).
|
|
"""
|
|
_client.put_object(
|
|
Bucket=settings.MINIO_BUCKET,
|
|
Key=key,
|
|
Body=content,
|
|
)
|
|
return key
|
|
|
|
|
|
def get_presigned_url(key: str, expiration: int = 3600) -> str:
|
|
"""Return a presigned GET URL for *key* valid for *expiration* seconds."""
|
|
return _client.generate_presigned_url(
|
|
"get_object",
|
|
Params={"Bucket": settings.MINIO_BUCKET, "Key": key},
|
|
ExpiresIn=expiration,
|
|
)
|