kitos
504dfc52f5
Aegis CI / lint-and-test (push) Has been cancelled
Snyk Security Scan / Python vulnerabilities (backend) (push) Has been cancelled
Snyk Security Scan / npm vulnerabilities (frontend) (push) Has been cancelled
Snyk Security Scan / Docker image vulnerabilities (backend) (push) Has been cancelled
Login is now by email, not username. username still exists internally (JWT sub claim, audit logs, Jira actor attribution, SSO provisioning all still key off it) but is now always kept equal to email everywhere a user is created or their email changes — never a separately-chosen value. - User.email is now unique + NOT NULL (migration b067 backfills any missing/blank email from username first, so existing rows — notably the seeded admin, which historically had none — never violate it). - /auth/login and the (unused but updated for consistency) authenticate_user() now query by email. - create_user (legacy, unreferenced but kept) and create_user_without_password both derive username from email. - update_user keeps username in sync when email changes, and rejects duplicate emails. - seed.py reads ADMIN_EMAIL (new env var, wired through install.sh and docker-compose.prod.yml) for the initial admin; falls back to an email-shaped ADMIN_USERNAME or a placeholder that's flagged for the operator to fix. - admin_config.py's import bundle now matches/creates users by email, skipping (not crashing on) entries with no email. - sso_service.py always sets username = email for SSO-provisioned users. - LoginPage/auth.ts updated to email input/copy (wire field name stays 'username' — that's the OAuth2PasswordRequestForm spec, not the value).
59 lines
1.8 KiB
Python
59 lines
1.8 KiB
Python
"""Tests for login attempt auditing (SEC-009)."""
|
|
|
|
from app.models.audit import AuditLog
|
|
|
|
|
|
def test_login_failed_creates_audit_entry(client, admin_user, db):
|
|
response = client.post(
|
|
"/api/v1/auth/login",
|
|
data={"username": "admin@test.com", "password": "wrong"},
|
|
headers={"X-Forwarded-For": "198.51.100.10", "User-Agent": "LoginAuditTest/1.0"},
|
|
)
|
|
assert response.status_code == 400
|
|
|
|
log = (
|
|
db.query(AuditLog)
|
|
.filter(AuditLog.action == "LOGIN_FAILED")
|
|
.order_by(AuditLog.timestamp.desc())
|
|
.first()
|
|
)
|
|
assert log is not None
|
|
assert log.entity_type == "auth"
|
|
assert log.details["email"] == "admin@test.com"
|
|
assert log.details["reason"] == "invalid_credentials"
|
|
assert log.ip_address == "198.51.100.10"
|
|
assert log.user_agent == "LoginAuditTest/1.0"
|
|
assert log.integrity_hash
|
|
|
|
|
|
def test_login_success_creates_audit_entry(client, admin_user, db):
|
|
client.cookies.clear()
|
|
response = client.post(
|
|
"/api/v1/auth/login",
|
|
data={"username": "admin@test.com", "password": "admin123"},
|
|
headers={"X-Forwarded-For": "198.51.100.20"},
|
|
)
|
|
assert response.status_code == 200
|
|
|
|
log = (
|
|
db.query(AuditLog)
|
|
.filter(AuditLog.action == "LOGIN_SUCCESS")
|
|
.order_by(AuditLog.timestamp.desc())
|
|
.first()
|
|
)
|
|
assert log is not None
|
|
assert log.user_id == admin_user.id
|
|
assert log.ip_address == "198.51.100.20"
|
|
assert log.integrity_hash
|
|
|
|
|
|
def test_login_unknown_user_still_audited(client, db):
|
|
response = client.post(
|
|
"/api/v1/auth/login",
|
|
data={"username": "nobody", "password": "password"},
|
|
)
|
|
assert response.status_code == 400
|
|
log = db.query(AuditLog).filter(AuditLog.action == "LOGIN_FAILED").first()
|
|
assert log is not None
|
|
assert log.user_id is None
|