Commit Graph

6 Commits

Author SHA1 Message Date
kitos 6749daa7cb feat(campaigns): add get_campaign_timeline service function 2026-07-04 12:02:09 +02:00
kitos fd47db7bea fix(campaigns): null-safe test_id serialization, correct stale comments
serialize_modification_request crashed toward a string 'None' instead of
JSON null for requests whose test_id was nulled by the SET NULL cascade.
Also corrects two comments that still described the debunked ordering
theory instead of the actual SET NULL fix, and fixes a test that
asserted post-cascade state without committing first (the ORM only
picks up out-of-band DB-side SET NULL on already-loaded objects after
expire_on_commit forces a re-read, matching real router behavior).
2026-07-04 12:02:09 +02:00
kitos 12a5484003 fix(campaigns): preserve modification-request audit row after test deletion
Approving a remove_test modification request deletes the underlying Test
row, which was cascading through test_id's ON DELETE CASCADE and wiping
out the request row itself before it could be read back. Changed to
ON DELETE SET NULL so the audit record (justification, reviewer,
decision) survives. Adds regression coverage plus double-approve/reject
idempotency tests.
2026-07-04 12:02:09 +02:00
kitos dc5f206bf5 feat(campaigns): gate test edits to draft, add modification request workflow 2026-07-04 12:02:09 +02:00
kitos 6eadc7405b test(campaigns): add EntityNotFoundError and reject-clears-approval coverage 2026-07-04 12:02:09 +02:00
kitos 385d402a57 feat(campaigns): submit/approve/reject service functions 2026-07-04 12:02:09 +02:00