Commit Graph

5 Commits

Author SHA1 Message Date
kitos 5bc71f677f refactor(campaigns): remove dead future-start_date scheduling code
Now that only the manager sets start_date, and only at the moment of
approval (which immediately activates the campaign), a draft campaign
can never have a start_date. This made three things permanently
unreachable: the hourly _run_scheduled_campaign_activation cron job,
the activate_campaign 409/force future-date guard, and a query filter
hiding tests from scheduled-but-inactive draft campaigns. Removes all
three rather than leaving dead code behind. Also adds the missing
manager-cannot-directly-activate router test.
2026-07-04 12:02:10 +02:00
kitos 959def2f49 feat(campaigns): timeline endpoint, admin-only manual activation, remove lead-set dates 2026-07-04 12:02:09 +02:00
kitos 6186c246a4 feat(campaigns): modification-request router endpoints 2026-07-04 12:02:09 +02:00
kitos 95b5ac50c6 test(campaigns): promote cookie-safe request helper to shared conftest fixture
Moves the local _post cookie-clearing helper into a shared 'api' fixture
in conftest.py so later router tests in this plan (Tasks 10/11) don't
have to reinvent or forget the TestClient cookie-vs-Authorization-header
gotcha. Also adds a one-line comment at both require_any_role("manager")
call sites clarifying admin passthrough is automatic.
2026-07-04 12:02:09 +02:00
kitos 4f5ffcf3f9 feat(campaigns): submit/approve/reject router endpoints 2026-07-04 12:02:09 +02:00