feat(tests): attack_success 3-value UI, data classification badge, reorder containment options

frontend/src/pages/ImportRTPage.tsx

@@ -34,7 +34,7 @@ const TEMPLATE_JSON: RTImportPayload = {
     {
       mitre_id: "T1059.001",
       result: "detected",
-      attack_success: true,
+      attack_success: "successful",
       platform: "windows",
       notes: "PowerShell execution caught by Defender for Endpoint within 2 min",
       evidence: [
@@ -48,7 +48,7 @@ const TEMPLATE_JSON: RTImportPayload = {
     {
       mitre_id: "T1078",
       result: "not_detected",
-      attack_success: true,
+      attack_success: "successful",
       platform: "windows",
       notes: "Credential reuse via stolen credentials — undetected for 48h",
       evidence: [
@@ -67,7 +67,7 @@ const TEMPLATE_JSON: RTImportPayload = {
     {
       mitre_id: "T1486",
       result: "not_detected",
-      attack_success: false,
+      attack_success: "not_successful",
       platform: "windows",
       notes: "Ransomware blocked by AppLocker before execution",
       evidence: [
@@ -81,7 +81,7 @@ const TEMPLATE_JSON: RTImportPayload = {
     {
       mitre_id: "T1190",
       result: "partially_detected",
-      attack_success: true,
+      attack_success: "partially_successful",
       platform: "linux",
       notes: "Exploit worked but only a partial alert fired — no full incident created",
       evidence: [
@@ -231,7 +231,7 @@ export default function ImportRTPage() {
                       ["name", "string", "Engagement name"],
                       ["techniques[].mitre_id", "string", "e.g. T1059.001"],
                       ["techniques[].result", "enum", "detected | not_detected | partially_detected"],
-                      ["techniques[].attack_success", "boolean", "Was the attack successful?"],
+                      ["techniques[].attack_success", "enum", "successful | not_successful | partially_successful"],
                       ["techniques[].evidence", "array", "Min 1 image required per technique"],
                       ["techniques[].evidence[].filename", "string", "e.g. screenshot_edr.png"],
                       ["techniques[].evidence[].data", "string", "Base64-encoded image (PNG/JPG/GIF/WebP/BMP, max 10 MB)"],
@@ -299,7 +299,7 @@ export default function ImportRTPage() {
         <textarea
           value={jsonText}
           onChange={(e) => handleTextChange(e.target.value)}
-          placeholder={`Paste your JSON here or use the template…\n\n{\n  "name": "Red Team Q1 2024",\n  "techniques": [\n    {\n      "mitre_id": "T1059.001",\n      "result": "detected",\n      "attack_success": true\n    }\n  ]\n}`}
+          placeholder={`Paste your JSON here or use the template…\n\n{\n  "name": "Red Team Q1 2024",\n  "techniques": [\n    {\n      "mitre_id": "T1059.001",\n      "result": "detected",\n      "attack_success": "successful"\n    }\n  ]\n}`}
           rows={14}
           className="w-full rounded-lg border border-gray-700 bg-gray-800 px-3 py-2.5 font-mono text-xs text-gray-200 placeholder-gray-600 focus:border-cyan-500 focus:outline-none resize-none"
         />
@@ -361,10 +361,13 @@ export default function ImportRTPage() {
                       </span>
                     </td>
                     <td className="px-4 py-2.5">
-                      {t.attack_success
-                        ? <span className="text-orange-400">Success</span>
-                        : <span className="text-gray-500">Blocked</span>
-                      }
+                      {t.attack_success === "successful" ? (
+                        <span className="text-orange-400">Success</span>
+                      ) : t.attack_success === "partially_successful" ? (
+                        <span className="text-yellow-400">Partial</span>
+                      ) : (
+                        <span className="text-gray-500">Blocked</span>
+                      )}
                     </td>
                     <td className="px-4 py-2.5 text-gray-400 capitalize">{t.platform ?? "—"}</td>
                     <td className="px-4 py-2.5 text-gray-500 max-w-xs truncate">{t.notes ?? "—"}</td>

frontend/src/pages/TestDetailPage.tsx

@@ -22,12 +22,13 @@ import {
   resumeTimer,
   holdTest,
   resumeTest,
+  updateTestClassification,
   getTestTimeline,
   getRetestChain,
 } from "../api/tests";
 import { uploadEvidence, getEvidence } from "../api/evidence";
 import { useAuth } from "../context/AuthContext";
-import type { TestResult, ContainmentResult, TeamSide, TestTimelineEntry } from "../types/models";
+import type { TestResult, ContainmentResult, AttackSuccessResult, DataClassification, TeamSide, TestTimelineEntry } from "../types/models";
 
 import TestDetailHeader from "../components/test-detail/TestDetailHeader";
 import TeamTabs from "../components/test-detail/TeamTabs";
@@ -72,10 +73,17 @@ export default function TestDetailPage() {
   const [holdModal, setHoldModal] = useState(false);
   const [holdReason, setHoldReason] = useState("");
 
-  const [redDraft, setRedDraft] = useState({
+  const [redDraft, setRedDraft] = useState<{
+    procedure_text: string;
+    tool_used: string;
+    attack_success: AttackSuccessResult | "";
+    red_summary: string;
+    execution_start_time: string;
+    execution_end_time: string;
+  }>({
     procedure_text: "",
     tool_used: "",
-    attack_success: false,
+    attack_success: "",
     red_summary: "",
     execution_start_time: "",
     execution_end_time: "",
@@ -131,7 +139,7 @@ export default function TestDetailPage() {
       setRedDraft({
         procedure_text: test.procedure_text || "",
         tool_used: test.tool_used || "",
-        attack_success: test.attack_success ?? false,
+        attack_success: test.attack_success ?? "",
         red_summary: test.red_summary || "",
         execution_start_time: isoToDatetimeLocal(test.execution_start_time),
         execution_end_time: isoToDatetimeLocal(test.execution_end_time),
@@ -179,7 +187,7 @@ export default function TestDetailPage() {
       updateTestRed(testId!, {
         procedure_text: redDraft.procedure_text || undefined,
         tool_used: redDraft.tool_used || undefined,
-        attack_success: redDraft.attack_success,
+        attack_success: redDraft.attack_success || undefined,
         red_summary: redDraft.red_summary || undefined,
         execution_start_time: redDraft.execution_start_time || undefined,
         execution_end_time: redDraft.execution_end_time || undefined,
@@ -351,6 +359,15 @@ export default function TestDetailPage() {
     onError: (err: unknown) => showToast(extractError(err), "error"),
   });
 
+  const updateClassificationMutation = useMutation({
+    mutationFn: (value: DataClassification) => updateTestClassification(testId!, value),
+    onSuccess: () => {
+      invalidateAll();
+      showToast("Data classification updated", "success");
+    },
+    onError: (err: unknown) => showToast(extractError(err), "error"),
+  });
+
   // Evidence upload
   const uploadMutation = useMutation({
     mutationFn: ({ file, team }: { file: File; team: TeamSide }) =>
@@ -513,6 +530,8 @@ export default function TestDetailPage() {
         onHold={() => setHoldModal(true)}
         onResume={() => resumeHoldMutation.mutate()}
         isTogglingHold={holdMutation.isPending || resumeHoldMutation.isPending}
+        onUpdateClassification={(value) => updateClassificationMutation.mutate(value)}
+        isUpdatingClassification={updateClassificationMutation.isPending}
       />
 
       {/* Content: Tabs + Sidebar */}

frontend/src/pages/ValidatedTestsPage.tsx

@@ -13,7 +13,7 @@ import {
   Swords,
 } from "lucide-react";
 import { getTests } from "../api/tests";
-import type { Test, TestResult } from "../types/models";
+import type { Test, TestResult, AttackSuccessResult } from "../types/models";
 
 /* ── Result helpers ─────────────────────────────────────────────────── */
 
@@ -41,19 +41,23 @@ function DetectionBadge({ result }: { result: TestResult | null | undefined }) {
   );
 }
 
-function AttackBadge({ success }: { success: boolean | null | undefined }) {
+function AttackBadge({ success }: { success: AttackSuccessResult | null | undefined }) {
   if (success === null || success === undefined)
     return <span className="text-gray-600 text-xs">—</span>;
+  const isSuccess = success === "successful";
+  const isPartial = success === "partially_successful";
   return (
     <span
       className={`inline-flex items-center gap-1 rounded-full border px-2 py-0.5 text-xs font-medium ${
-        success
+        isSuccess
           ? "bg-orange-500/10 text-orange-400 border-orange-500/20"
-          : "bg-gray-500/10 text-gray-400 border-gray-600/20"
+          : isPartial
+            ? "bg-yellow-500/10 text-yellow-400 border-yellow-500/20"
+            : "bg-gray-500/10 text-gray-400 border-gray-600/20"
       }`}
     >
       <Swords className="h-3 w-3" />
-      {success ? "Success" : "Blocked"}
+      {isSuccess ? "Success" : isPartial ? "Partial" : "Blocked"}
     </span>
   );
 }