From a8542512b4c7fb6744da815f895c6bc270ebf3cc Mon Sep 17 00:00:00 2001
From: kitos <kitos@aegis.local>
Date: Thu, 28 May 2026 17:55:04 +0200
Subject: [PATCH] fix(ui+backend): sidebar active state + technique status
 after test deletion

- Sidebar: add `end` prop to child NavLinks so "All Tests" (/tests) is
  only highlighted when exactly on /tests, not on /tests/validated.
- Backend: recalculate technique status_global for all affected techniques
  when tests are deleted via delete_campaign(delete_tests=True), preventing
  stale coverage metrics on the dashboard.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 backend/app/services/campaign_crud_service.py | 11 +++++++++++
 frontend/src/components/Sidebar.tsx           |  1 +
 2 files changed, 12 insertions(+)

diff --git a/backend/app/services/campaign_crud_service.py b/backend/app/services/campaign_crud_service.py
index edae68b..3dc7714 100644
--- a/backend/app/services/campaign_crud_service.py
+++ b/backend/app/services/campaign_crud_service.py
@@ -25,6 +25,7 @@ from app.services.campaign_service import (
     TACTIC_TO_PHASE,
 )
 from app.services.campaign_scheduler_service import calculate_next_run
+from app.services.status_service import recalculate_technique_status
 
 
 # ── Serialization helpers ────────────────────────────────────────────────
@@ -465,11 +466,21 @@ def delete_campaign(
 
     # Optionally delete the associated tests
     if delete_tests:
+        affected_technique_ids: set = set()
         for test_id in test_ids:
             test = db.query(Test).filter(Test.id == test_id).first()
             if test:
+                if test.technique_id:
+                    affected_technique_ids.add(test.technique_id)
                 db.delete(test)
         db.flush()
+        # Recalculate status_global for every affected technique so the
+        # coverage metrics stay consistent after test deletion.
+        for tech_id in affected_technique_ids:
+            technique = db.query(Technique).filter(Technique.id == tech_id).first()
+            if technique:
+                recalculate_technique_status(db, technique)
+        db.flush()
 
     # Null-out parent_campaign_id on child campaigns to avoid FK violation
     db.query(Campaign).filter(Campaign.parent_campaign_id == campaign.id).update(
diff --git a/frontend/src/components/Sidebar.tsx b/frontend/src/components/Sidebar.tsx
index 499519b..75ba504 100644
--- a/frontend/src/components/Sidebar.tsx
+++ b/frontend/src/components/Sidebar.tsx
@@ -82,6 +82,7 @@ function SidebarLink({ item }: { item: NavItem }) {
               <NavLink
                 key={child.to + child.label}
                 to={child.to}
+                end
                 className={({ isActive }) =>
                   `flex items-center gap-3 rounded-lg px-3 py-2 text-sm transition-colors ${
                     isActive