feat(refactor): PEP8, type annotations, docstrings and PyJWT security fix

backend/app/services/technique_query_service.py

@@ -1,9 +1,14 @@
 """Technique query service — framework-agnostic queries for technique details."""
+# Enable future language features for compatibility
 from __future__ import annotations
 
+# Import Session, joinedload from sqlalchemy.orm
 from sqlalchemy.orm import Session, joinedload
 
+# Import EntityNotFoundError from app.domain.errors
 from app.domain.errors import EntityNotFoundError
+
+# Import Technique from app.models.technique
 from app.models.technique import Technique
 from app.models.detection_rule import DetectionRule
 from app.models.intel import IntelItem
@@ -13,15 +18,21 @@ from app.services.d3fend_import_service import get_defenses_for_technique
 _SEVERITY_ORDER = {"critical": 0, "high": 1, "medium": 2, "low": 3, "informational": 4, None: 5}
 
 
+# Define function get_technique_detail
 def get_technique_detail(db: Session, mitre_id: str) -> dict:
     """Fetch full technique details including tests, detection rules, and D3FEND defenses."""
     technique = (
         db.query(Technique)
+        # Chain .options() call
         .options(joinedload(Technique.tests))
+        # Chain .filter() call
         .filter(Technique.mitre_id == mitre_id)
+        # Chain .first() call
         .first()
     )
+    # Check: technique is None
     if technique is None:
+        # Raise EntityNotFoundError
         raise EntityNotFoundError("Technique", mitre_id)
 
     defenses = get_defenses_for_technique(db, technique.id)
@@ -49,26 +60,46 @@ def get_technique_detail(db: Session, mitre_id: str) -> dict:
     )
 
     return {
+        # Literal argument value
         "id": str(technique.id),
+        # Literal argument value
         "mitre_id": technique.mitre_id,
+        # Literal argument value
         "name": technique.name,
+        # Literal argument value
         "description": technique.description,
+        # Literal argument value
         "tactic": technique.tactic,
+        # Literal argument value
         "platforms": technique.platforms or [],
+        # Literal argument value
         "mitre_version": technique.mitre_version,
+        # Literal argument value
         "mitre_last_modified": technique.mitre_last_modified,
+        # Literal argument value
         "is_subtechnique": technique.is_subtechnique,
+        # Literal argument value
         "parent_mitre_id": technique.parent_mitre_id,
+        # Literal argument value
         "status_global": technique.status_global.value if technique.status_global else "not_evaluated",
+        # Literal argument value
         "review_required": technique.review_required,
+        # Literal argument value
         "last_review_date": technique.last_review_date,
+        # Literal argument value
         "tests": [
             {
+                # Literal argument value
                 "id": str(t.id),
+                # Literal argument value
                 "name": t.name,
+                # Literal argument value
                 "state": t.state.value if t.state else None,
+                # Literal argument value
                 "result": t.result.value if t.result else None,
+                # Literal argument value
                 "platform": t.platform,
+                # Literal argument value
                 "created_at": t.created_at.isoformat() if t.created_at else None,
             }
             for t in technique.tests