From 8d9e25703d8a152f7cb5bb2c6ee4f2b3b1dc5f3e Mon Sep 17 00:00:00 2001
From: kitos <kitos@aegis.local>
Date: Wed, 15 Jul 2026 16:49:43 +0200
Subject: [PATCH] fix(campaigns): make Expected Detection editable when adding
 a test to a campaign

Was a read-only reference shown only when the template already had
content, unlike the standalone create-from-template form where it's
an editable field feeding detect_procedure on the new test. Brought
the campaign flow in line with that so leads get the same editing
capability regardless of whether the test is going into a campaign.
---
 .../src/components/AddTestToCampaignModal.tsx | 30 ++++++++++---------
 1 file changed, 16 insertions(+), 14 deletions(-)

diff --git a/frontend/src/components/AddTestToCampaignModal.tsx b/frontend/src/components/AddTestToCampaignModal.tsx
index e009b77..d85fda9 100644
--- a/frontend/src/components/AddTestToCampaignModal.tsx
+++ b/frontend/src/components/AddTestToCampaignModal.tsx
@@ -89,6 +89,7 @@ export default function AddTestToCampaignModal({
   const [formPlatform, setFormPlatform] = useState("");
   const [formProcedure, setFormProcedure] = useState("");
   const [formTool, setFormTool] = useState("");
+  const [formExpectedDetection, setFormExpectedDetection] = useState("");
 
   // ── reset when closed ────────────────────────────────────────────
   useEffect(() => {
@@ -143,6 +144,7 @@ export default function AddTestToCampaignModal({
       setFormPlatform(fullTemplate.platform || "");
       setFormProcedure(fullTemplate.attack_procedure || "");
       setFormTool(fullTemplate.tool_suggested || "");
+      setFormExpectedDetection(fullTemplate.expected_detection || "");
     }
   }, [fullTemplate]);
 
@@ -179,6 +181,7 @@ export default function AddTestToCampaignModal({
           platform: formPlatform.trim() || undefined,
           procedure_text: formProcedure.trim() || undefined,
           tool_used: formTool.trim() || undefined,
+          detect_procedure: formExpectedDetection.trim() || undefined,
         },
       );
       await addTestToCampaign(campaignId, { test_id: test.id });
@@ -455,20 +458,19 @@ export default function AddTestToCampaignModal({
                     />
                   </div>
 
-                  {/* Expected detection — read-only reference */}
-                  {fullTemplate?.expected_detection && (
-                    <div>
-                      <label className="mb-1.5 block text-sm font-medium text-gray-300">
-                        Expected Detection
-                        <span className="ml-2 text-xs text-gray-500">(reference — Blue Team)</span>
-                      </label>
-                      <div className="rounded-lg border border-gray-700 bg-gray-800/50 p-3">
-                        <p className="whitespace-pre-wrap font-mono text-xs text-gray-400">
-                          {fullTemplate.expected_detection}
-                        </p>
-                      </div>
-                    </div>
-                  )}
+                  {/* Expected Detection */}
+                  <div>
+                    <label className="mb-1.5 block text-sm font-medium text-gray-300">
+                      Expected Detection
+                    </label>
+                    <textarea
+                      value={formExpectedDetection}
+                      onChange={(e) => setFormExpectedDetection(e.target.value)}
+                      rows={4}
+                      className="w-full rounded-lg border border-gray-700 bg-gray-800 px-3 py-2 font-mono text-sm text-gray-200 placeholder-gray-500 focus:border-cyan-500 focus:outline-none"
+                      placeholder="What the blue team should detect, and how..."
+                    />
+                  </div>
 
                   {/* Error */}
                   {createAndAddMutation.isError && (