feat(phase-11): implement Red/Blue business logic services (T-106, T-107, T-108)

T-106: Create test_workflow_service.py with state-machine transitions for the complete test lifecycle (draft -> red_executing -> blue_evaluating -> in_review -> validated/rejected), dual validation by Red/Blue leads, and reopen capability with field cleanup. T-107: Update status_service.py to use detection_result from Blue Team instead of legacy result field, and differentiate between partial progress (some validated) vs all-in-progress states. T-108: Create atomic_import_service.py that downloads the Atomic Red Team repo as a ZIP (avoiding API rate limits), parses all atomics YAML files, and creates idempotent TestTemplate records mapped to MITRE techniques. Includes validation tests for all three tasks (19 checks total).
2026-02-09 09:58:54 +01:00
parent 086cc5c8bc
commit 7af6be10be
23 changed files with 2053 additions and 45 deletions
--- a/backend/alembic/versions/b003_add_dual_validation_fields.py
+++ b/backend/alembic/versions/b003_add_dual_validation_fields.py
@@ -0,0 +1,87 @@
+"""add_dual_validation_fields_to_tests
+
+Revision ID: b003dualvalid
+Revises: b002evidteam
+Create Date: 2026-02-09 10:02:00.000000
+
+"""
+from typing import Sequence, Union
+
+from alembic import op
+import sqlalchemy as sa
+from sqlalchemy.dialects import postgresql
+
+
+# revision identifiers, used by Alembic.
+revision: str = 'b003dualvalid'
+down_revision: Union[str, Sequence[str], None] = 'b002evidteam'
+branch_labels: Union[str, Sequence[str], None] = None
+depends_on: Union[str, Sequence[str], None] = None
+
+
+def upgrade() -> None:
+    """Drop legacy validated_by/validated_at and add dual validation columns."""
+    # Drop legacy single-validation columns
+    op.drop_constraint('tests_validated_by_fkey', 'tests', type_='foreignkey')
+    op.drop_column('tests', 'validated_by')
+    op.drop_column('tests', 'validated_at')
+
+    # ── Red Team fields ─────────────────────────────────────────
+    op.add_column('tests', sa.Column('red_summary', sa.Text(), nullable=True))
+    op.add_column('tests', sa.Column('attack_success', sa.Boolean(), nullable=True))
+    op.add_column('tests', sa.Column('red_validated_by', sa.UUID(), nullable=True))
+    op.add_column('tests', sa.Column('red_validated_at', sa.DateTime(), nullable=True))
+    op.add_column('tests', sa.Column('red_validation_status', sa.String(), nullable=True))
+    op.add_column('tests', sa.Column('red_validation_notes', sa.Text(), nullable=True))
+
+    # ── Blue Team fields ────────────────────────────────────────
+    op.add_column('tests', sa.Column('blue_summary', sa.Text(), nullable=True))
+    op.add_column('tests', sa.Column(
+        'detection_result',
+        postgresql.ENUM('detected', 'not_detected', 'partially_detected',
+                        name='testresult', create_type=False),
+        nullable=True,
+    ))
+    op.add_column('tests', sa.Column('blue_validated_by', sa.UUID(), nullable=True))
+    op.add_column('tests', sa.Column('blue_validated_at', sa.DateTime(), nullable=True))
+    op.add_column('tests', sa.Column('blue_validation_status', sa.String(), nullable=True))
+    op.add_column('tests', sa.Column('blue_validation_notes', sa.Text(), nullable=True))
+
+    # ── Foreign keys ────────────────────────────────────────────
+    op.create_foreign_key(
+        'fk_tests_red_validated_by', 'tests', 'users',
+        ['red_validated_by'], ['id'],
+    )
+    op.create_foreign_key(
+        'fk_tests_blue_validated_by', 'tests', 'users',
+        ['blue_validated_by'], ['id'],
+    )
+
+
+def downgrade() -> None:
+    """Reverse: drop dual validation columns and restore legacy columns."""
+    # Drop FKs
+    op.drop_constraint('fk_tests_blue_validated_by', 'tests', type_='foreignkey')
+    op.drop_constraint('fk_tests_red_validated_by', 'tests', type_='foreignkey')
+
+    # Drop new columns
+    op.drop_column('tests', 'blue_validation_notes')
+    op.drop_column('tests', 'blue_validation_status')
+    op.drop_column('tests', 'blue_validated_at')
+    op.drop_column('tests', 'blue_validated_by')
+    op.drop_column('tests', 'detection_result')
+    op.drop_column('tests', 'blue_summary')
+    op.drop_column('tests', 'red_validation_notes')
+    op.drop_column('tests', 'red_validation_status')
+    op.drop_column('tests', 'red_validated_at')
+    op.drop_column('tests', 'red_validated_by')
+    op.drop_column('tests', 'attack_success')
+    op.drop_column('tests', 'red_summary')
+
+    # Restore legacy columns
+    op.add_column('tests', sa.Column('validated_by', sa.UUID(), nullable=True))
+    op.add_column('tests', sa.Column('validated_at', sa.DateTime(), nullable=True))
+    op.create_foreign_key(
+        'tests_validated_by_fkey', 'tests', 'users',
+        ['validated_by'], ['id'],
+    )