fix(jira,tests): clarify manager-resolved disputes in Jira and the Summary tab
Aegis CI / lint-and-test (push) Has been cancelled
Snyk Security Scan / Python vulnerabilities (backend) (push) Has been cancelled
Snyk Security Scan / npm vulnerabilities (frontend) (push) Has been cancelled
Snyk Security Scan / Docker image vulnerabilities (backend) (push) Has been cancelled
Aegis CI / lint-and-test (push) Has been cancelled
Snyk Security Scan / Python vulnerabilities (backend) (push) Has been cancelled
Snyk Security Scan / npm vulnerabilities (frontend) (push) Has been cancelled
Snyk Security Scan / Docker image vulnerabilities (backend) (push) Has been cancelled
The validated/rejected Jira comment always said 'by both leads' and never carried the manager's own notes, even when a manager had just overridden two disagreeing votes — misleading, since that combination of statuses is only reachable via a manager decision. Now detected from the disagreement itself and worded accordingly, with the manager's notes included via the existing extra-data mechanism. Also reworks the Summary tab: Final Result moves to the top (was the very last thing on the page) and now shows Containment alongside Detection — previously the only place Containment appeared at all was inside the editable Blue tab. Both team cards now show the validating lead's notes, not just the approved/rejected badge, and flag when a manager's decision resolved a disagreement between the two leads.
This commit is contained in:
@@ -698,8 +698,51 @@ export default function TeamTabs({
|
||||
|
||||
// ── Summary Tab ──────────────────────────────────────────────────
|
||||
|
||||
const renderSummaryTab = () => (
|
||||
const renderSummaryTab = () => {
|
||||
// A disputed test resolved by a manager keeps the leads' original,
|
||||
// disagreeing votes (one approved, one rejected) — that combination is
|
||||
// otherwise unreachable, since normal dual-validation requires both
|
||||
// leads to agree. Use it to tell the two paths apart, same signal used
|
||||
// for the Jira comment.
|
||||
const managerResolved =
|
||||
!!test.red_validation_status &&
|
||||
!!test.blue_validation_status &&
|
||||
test.red_validation_status !== test.blue_validation_status &&
|
||||
(test.state === "validated" || test.state === "rejected");
|
||||
|
||||
return (
|
||||
<div className="space-y-6">
|
||||
{/* Final Result — shown first: the single most important thing to
|
||||
know at a glance, especially right after a manager's decision. */}
|
||||
<div className="rounded-lg border border-gray-700 bg-gray-800/50 p-4">
|
||||
<h3 className="mb-2 text-sm font-semibold text-gray-300">Final Result</h3>
|
||||
<div className="flex flex-wrap items-center gap-4">
|
||||
<div className="flex items-center gap-2">
|
||||
<span className="text-xs text-gray-500">State:</span>
|
||||
<span className="text-sm font-medium capitalize text-gray-200">
|
||||
{test.state.replace(/_/g, " ")}
|
||||
</span>
|
||||
</div>
|
||||
<div className="flex items-center gap-2">
|
||||
<span className="text-xs text-gray-500">Detection:</span>
|
||||
<span className="text-sm font-medium capitalize text-gray-200">
|
||||
{test.detection_result ? test.detection_result.replace(/_/g, " ") : "Not evaluated"}
|
||||
</span>
|
||||
</div>
|
||||
<div className="flex items-center gap-2">
|
||||
<span className="text-xs text-gray-500">Containment:</span>
|
||||
<span className="text-sm font-medium capitalize text-gray-200">
|
||||
{test.containment_result ? test.containment_result.replace(/_/g, " ") : "Not evaluated"}
|
||||
</span>
|
||||
</div>
|
||||
</div>
|
||||
{managerResolved && (
|
||||
<p className="mt-2 text-xs text-purple-300">
|
||||
Resolved by a manager's decision — the leads disagreed (Red: {test.red_validation_status}, Blue: {test.blue_validation_status}).
|
||||
</p>
|
||||
)}
|
||||
</div>
|
||||
|
||||
{/* Side-by-side comparison */}
|
||||
<div className="grid gap-6 md:grid-cols-2">
|
||||
{/* Red Side */}
|
||||
@@ -752,6 +795,9 @@ export default function TeamTabs({
|
||||
<><XCircle className="h-3.5 w-3.5 text-red-400" /><span className="text-red-400">Rejected</span></>
|
||||
)}
|
||||
</dd>
|
||||
{test.red_validation_notes && (
|
||||
<dd className="mt-1"><MarkdownText content={test.red_validation_notes} className="text-xs text-gray-400 italic" /></dd>
|
||||
)}
|
||||
</div>
|
||||
)}
|
||||
</dl>
|
||||
@@ -783,6 +829,28 @@ export default function TeamTabs({
|
||||
)}
|
||||
</dd>
|
||||
</div>
|
||||
{(test.detection_result === "detected" || test.detection_result === "partially_detected") && (
|
||||
<div>
|
||||
<dt className="text-xs font-medium uppercase text-gray-500">Containment Result</dt>
|
||||
<dd className="mt-0.5 text-sm">
|
||||
{test.containment_result ? (
|
||||
<span
|
||||
className={`inline-flex rounded-full border px-2 py-0.5 text-xs font-medium ${
|
||||
test.containment_result === "contained"
|
||||
? "border-green-500/30 bg-green-900/50 text-green-400"
|
||||
: test.containment_result === "not_contained"
|
||||
? "border-red-500/30 bg-red-900/50 text-red-400"
|
||||
: "border-yellow-500/30 bg-yellow-900/50 text-yellow-400"
|
||||
}`}
|
||||
>
|
||||
{test.containment_result.replace(/_/g, " ")}
|
||||
</span>
|
||||
) : (
|
||||
<span className="text-gray-500">Not evaluated</span>
|
||||
)}
|
||||
</dd>
|
||||
</div>
|
||||
)}
|
||||
<div>
|
||||
<dt className="text-xs font-medium uppercase text-gray-500">Summary</dt>
|
||||
<dd className="mt-0.5"><MarkdownText content={test.blue_summary || "N/A"} className="text-sm text-gray-300" /></dd>
|
||||
@@ -803,6 +871,9 @@ export default function TeamTabs({
|
||||
<><XCircle className="h-3.5 w-3.5 text-red-400" /><span className="text-red-400">Rejected</span></>
|
||||
)}
|
||||
</dd>
|
||||
{test.blue_validation_notes && (
|
||||
<dd className="mt-1"><MarkdownText content={test.blue_validation_notes} className="text-xs text-gray-400 italic" /></dd>
|
||||
)}
|
||||
</div>
|
||||
)}
|
||||
{test.system_gaps && (
|
||||
@@ -814,29 +885,9 @@ export default function TeamTabs({
|
||||
</dl>
|
||||
</div>
|
||||
</div>
|
||||
|
||||
{/* Final Result */}
|
||||
<div className="rounded-lg border border-gray-700 bg-gray-800/50 p-4">
|
||||
<h3 className="mb-2 text-sm font-semibold text-gray-300">Final Result</h3>
|
||||
<div className="flex items-center gap-4">
|
||||
<div className="flex items-center gap-2">
|
||||
<span className="text-xs text-gray-500">State:</span>
|
||||
<span className="text-sm font-medium capitalize text-gray-200">
|
||||
{test.state.replace(/_/g, " ")}
|
||||
</span>
|
||||
</div>
|
||||
{test.detection_result && (
|
||||
<div className="flex items-center gap-2">
|
||||
<span className="text-xs text-gray-500">Detection:</span>
|
||||
<span className="text-sm font-medium capitalize text-gray-200">
|
||||
{test.detection_result.replace(/_/g, " ")}
|
||||
</span>
|
||||
</div>
|
||||
)}
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
);
|
||||
);
|
||||
};
|
||||
|
||||
// ── Timeline Tab ─────────────────────────────────────────────────
|
||||
|
||||
|
||||
Reference in New Issue
Block a user