fix(jira,tests): clarify manager-resolved disputes in Jira and the Summary tab
Aegis CI / lint-and-test (push) Has been cancelled
Snyk Security Scan / Python vulnerabilities (backend) (push) Has been cancelled
Snyk Security Scan / npm vulnerabilities (frontend) (push) Has been cancelled
Snyk Security Scan / Docker image vulnerabilities (backend) (push) Has been cancelled
Aegis CI / lint-and-test (push) Has been cancelled
Snyk Security Scan / Python vulnerabilities (backend) (push) Has been cancelled
Snyk Security Scan / npm vulnerabilities (frontend) (push) Has been cancelled
Snyk Security Scan / Docker image vulnerabilities (backend) (push) Has been cancelled
The validated/rejected Jira comment always said 'by both leads' and never carried the manager's own notes, even when a manager had just overridden two disagreeing votes — misleading, since that combination of statuses is only reachable via a manager decision. Now detected from the disagreement itself and worded accordingly, with the manager's notes included via the existing extra-data mechanism. Also reworks the Summary tab: Final Result moves to the top (was the very last thing on the page) and now shows Containment alongside Detection — previously the only place Containment appeared at all was inside the editable Blue tab. Both team cards now show the validating lead's notes, not just the approved/rejected badge, and flag when a manager's decision resolved a disagreement between the two leads.
This commit is contained in:
@@ -516,8 +516,17 @@ def _build_state_comment(
|
||||
lines += ["", "h4. Remediation Steps", test.remediation_steps]
|
||||
|
||||
elif new_state == "validated":
|
||||
# A disputed test resolved by a manager keeps the leads' original,
|
||||
# disagreeing votes (one approved, one rejected) — that combination
|
||||
# is otherwise unreachable, since normal dual-validation requires
|
||||
# both leads to agree. Use it to tell the two paths apart.
|
||||
manager_resolved = (
|
||||
test.red_validation_status and test.blue_validation_status
|
||||
and test.red_validation_status != test.blue_validation_status
|
||||
)
|
||||
lines += [
|
||||
"Test has been *validated* by both leads.",
|
||||
"Test has been *validated* by a manager's decision on a disputed test."
|
||||
if manager_resolved else "Test has been *validated* by both leads.",
|
||||
"",
|
||||
f"*Red Lead Status:* {test.red_validation_status or 'N/A'}",
|
||||
f"*Blue Lead Status:* {test.blue_validation_status or 'N/A'}",
|
||||
@@ -528,8 +537,13 @@ def _build_state_comment(
|
||||
lines += ["", f"*Blue Lead Notes:* {test.blue_validation_notes}"]
|
||||
|
||||
elif new_state == "rejected":
|
||||
manager_resolved = (
|
||||
test.red_validation_status and test.blue_validation_status
|
||||
and test.red_validation_status != test.blue_validation_status
|
||||
)
|
||||
lines += [
|
||||
"Test has been *rejected* and must be reworked.",
|
||||
"Test has been *rejected* by a manager's decision on a disputed test."
|
||||
if manager_resolved else "Test has been *rejected* and must be reworked.",
|
||||
"",
|
||||
f"*Red Lead Status:* {test.red_validation_status or 'N/A'}",
|
||||
f"*Blue Lead Status:* {test.blue_validation_status or 'N/A'}",
|
||||
|
||||
Reference in New Issue
Block a user