refactor(campaigns): remove dead future-start_date scheduling code

Now that only the manager sets start_date, and only at the moment of
approval (which immediately activates the campaign), a draft campaign
can never have a start_date. This made three things permanently
unreachable: the hourly _run_scheduled_campaign_activation cron job,
the activate_campaign 409/force future-date guard, and a query filter
hiding tests from scheduled-but-inactive draft campaigns. Removes all
three rather than leaving dead code behind. Also adds the missing
manager-cannot-directly-activate router test.

backend/app/jobs/mitre_sync_job.py

@@ -164,96 +164,6 @@ def _run_recurring_campaigns() -> None:
         db.close()
 
 
-def _run_scheduled_campaign_activation() -> None:
-    """Auto-activate campaigns whose start_date has arrived.
-
-    Finds all campaigns in 'draft' state with a start_date <= now,
-    activates them, creates Jira tickets, and notifies the red_tech team.
-    Runs every hour so campaigns activate within ~1 hour of their scheduled time.
-    """
-    logger.info("Scheduled campaign auto-activation check starting...")
-    db = SessionLocal()
-    try:
-        from datetime import datetime as _dt
-        from app.models.campaign import Campaign
-        from app.models.user import User
-        from app.services.campaign_crud_service import activate_campaign as _activate
-        from app.services.notification_service import notify_role
-        from app.services.audit_service import log_action
-
-        now = _dt.utcnow()
-        due_campaigns = (
-            db.query(Campaign)
-            .filter(
-                Campaign.status == "draft",
-                Campaign.start_date != None,  # noqa: E711
-                Campaign.start_date <= now,
-            )
-            .all()
-        )
-
-        activated = 0
-        for campaign in due_campaigns:
-            try:
-                _activate(db, str(campaign.id))
-                notify_role(
-                    db,
-                    role="red_tech",
-                    type="campaign_activated",
-                    title="Campaign auto-activated",
-                    message=f'Campaign "{campaign.name}" has been automatically activated on its scheduled start date.',
-                    entity_type="campaign",
-                    entity_id=campaign.id,
-                )
-                log_action(
-                    db,
-                    user_id=None,
-                    action="auto_activate_campaign",
-                    entity_type="campaign",
-                    entity_id=campaign.id,
-                    details={"name": campaign.name, "start_date": str(campaign.start_date)},
-                )
-
-                # Create Jira tickets non-fatally
-                try:
-                    from app.services.jira_service import (
-                        auto_create_campaign_issue,
-                        auto_create_test_issue,
-                        get_campaign_jira_key,
-                        get_test_jira_key,
-                    )
-                    # Use first admin user as actor for Jira auth
-                    admin_user = db.query(User).filter(User.role == "admin").first()
-                    if admin_user:
-                        db.refresh(campaign)
-                        campaign_jira_key = get_campaign_jira_key(db, str(campaign.id))
-                        if not campaign_jira_key:
-                            campaign_jira_key = auto_create_campaign_issue(db, campaign, admin_user)
-                        if campaign_jira_key:
-                            for ct in campaign.campaign_tests:
-                                if ct.test and not get_test_jira_key(db, ct.test.id):
-                                    auto_create_test_issue(
-                                        db, ct.test, admin_user,
-                                        parent_ticket_override=campaign_jira_key,
-                                        campaign_start_date=campaign.start_date,
-                                    )
-                except Exception:
-                    logger.exception("Jira auto-create failed for auto-activated campaign %s", campaign.id)
-
-                db.commit()
-                activated += 1
-                logger.info("Auto-activated campaign %s (%s)", campaign.id, campaign.name)
-            except Exception:
-                logger.exception("Failed to auto-activate campaign %s", campaign.id)
-                db.rollback()
-
-        logger.info("Campaign auto-activation check finished — activated %d campaigns", activated)
-    except Exception:
-        logger.exception("Campaign auto-activation job failed")
-    finally:
-        db.close()
-
-
 def _run_intel_scan() -> None:
     """Execute an intel scan inside its own DB session."""
     # Log info: "Scheduled intel scan job starting..."
@@ -574,15 +484,6 @@ def start_scheduler() -> None:
         # Keyword argument: replace_existing
         replace_existing=True,
     )
-    # Call scheduler.add_job()
-    scheduler.add_job(
-        _run_scheduled_campaign_activation,
-        trigger="interval",
-        hours=1,
-        id="scheduled_campaign_activation",
-        name="Auto-activate campaigns on start_date (hourly)",
-        replace_existing=True,
-    )
     scheduler.add_job(
         _run_recurring_campaigns,
         # Keyword argument: trigger