fix(tests): restrict on-hold to techs and admin, remove leads
Aegis CI / lint-and-test (push) Waiting to run
Snyk Security Scan / Python vulnerabilities (backend) (push) Waiting to run
Snyk Security Scan / npm vulnerabilities (frontend) (push) Waiting to run
Snyk Security Scan / Docker image vulnerabilities (backend) (push) Waiting to run

This commit is contained in:
kitos
2026-06-19 10:01:42 +02:00
parent 4e1f35c250
commit 4e71217dd7
2 changed files with 3 additions and 3 deletions
+2 -2
View File
@@ -1131,7 +1131,7 @@ def hold_test(
test_id: uuid.UUID, test_id: uuid.UUID,
payload: TestHold, payload: TestHold,
db: Session = Depends(get_db), db: Session = Depends(get_db),
current_user: User = Depends(require_any_role("red_tech", "blue_tech", "red_lead", "blue_lead", "admin")), current_user: User = Depends(require_any_role("red_tech", "blue_tech", "admin")),
): ):
"""Place a test on hold with a mandatory reason. Posts comment + transitions Jira.""" """Place a test on hold with a mandatory reason. Posts comment + transitions Jira."""
from datetime import datetime as _dt from datetime import datetime as _dt
@@ -1171,7 +1171,7 @@ def hold_test(
def resume_test( def resume_test(
test_id: uuid.UUID, test_id: uuid.UUID,
db: Session = Depends(get_db), db: Session = Depends(get_db),
current_user: User = Depends(require_any_role("red_tech", "blue_tech", "red_lead", "blue_lead", "admin")), current_user: User = Depends(require_any_role("red_tech", "blue_tech", "admin")),
): ):
"""Resume a test that was placed on hold.""" """Resume a test that was placed on hold."""
from app.services.jira_service import push_hold_event from app.services.jira_service import push_hold_event
@@ -127,7 +127,7 @@ export default function TestDetailHeader({
const HOLDABLE_STATES: TestState[] = ["draft", "red_executing", "blue_evaluating"]; const HOLDABLE_STATES: TestState[] = ["draft", "red_executing", "blue_evaluating"];
const canHold = const canHold =
HOLDABLE_STATES.includes(test.state) && HOLDABLE_STATES.includes(test.state) &&
(role === "red_tech" || role === "blue_tech" || role === "red_lead" || role === "blue_lead" || role === "admin"); (role === "red_tech" || role === "blue_tech" || role === "admin");
const renderActions = () => { const renderActions = () => {
const buttons: React.ReactNode[] = []; const buttons: React.ReactNode[] = [];