feat(assign): let leads manually assign operators + sync Jira; send platform as Jira label
Aegis CI / lint-and-test (push) Has been cancelled
Snyk Security Scan / Python vulnerabilities (backend) (push) Has been cancelled
Snyk Security Scan / npm vulnerabilities (frontend) (push) Has been cancelled
Snyk Security Scan / Docker image vulnerabilities (backend) (push) Has been cancelled
Aegis CI / lint-and-test (push) Has been cancelled
Snyk Security Scan / Python vulnerabilities (backend) (push) Has been cancelled
Snyk Security Scan / npm vulnerabilities (frontend) (push) Has been cancelled
Snyk Security Scan / Docker image vulnerabilities (backend) (push) Has been cancelled
Adds GET /users/operators (leads+admin) and wires a lead-only assign
control into the test detail header, calling the existing but
previously unreachable POST /tests/{id}/assign endpoint. Manual
assignment now also pushes the Jira ticket assignee immediately
instead of waiting for the operator to start execution.
Also adds test.platform as a kebab-case label on Jira ticket creation.
This commit is contained in:
@@ -0,0 +1,111 @@
|
||||
"""Tests for POST /tests/{id}/assign — lead/admin manual operator assignment."""
|
||||
|
||||
from unittest.mock import MagicMock, patch
|
||||
|
||||
from app.models.test import Test
|
||||
from app.models.technique import Technique
|
||||
|
||||
|
||||
def _seed_technique(db, tactic="execution") -> Technique:
|
||||
technique = Technique(
|
||||
mitre_id="T9999",
|
||||
name="Test Technique",
|
||||
tactic=tactic,
|
||||
platforms=["linux"],
|
||||
)
|
||||
db.add(technique)
|
||||
db.commit()
|
||||
db.refresh(technique)
|
||||
return technique
|
||||
|
||||
|
||||
def _seed_test(db, technique, created_by) -> Test:
|
||||
test = Test(technique_id=technique.id, name="Assignable test", created_by=created_by)
|
||||
db.add(test)
|
||||
db.commit()
|
||||
db.refresh(test)
|
||||
return test
|
||||
|
||||
|
||||
def test_red_lead_can_assign_red_tech(client, db, red_lead_headers, red_lead_user, red_tech_user):
|
||||
technique = _seed_technique(db)
|
||||
test = _seed_test(db, technique, red_lead_user.id)
|
||||
|
||||
resp = client.post(
|
||||
f"/api/v1/tests/{test.id}/assign",
|
||||
json={"red_tech_assignee": str(red_tech_user.id)},
|
||||
headers=red_lead_headers,
|
||||
)
|
||||
assert resp.status_code == 200, resp.text
|
||||
assert resp.json()["red_tech_assignee"] == str(red_tech_user.id)
|
||||
|
||||
db.refresh(test)
|
||||
assert test.red_tech_assignee == red_tech_user.id
|
||||
|
||||
|
||||
def test_assign_rejects_wrong_role_for_side(client, db, red_lead_headers, red_lead_user, blue_tech_user):
|
||||
technique = _seed_technique(db)
|
||||
test = _seed_test(db, technique, red_lead_user.id)
|
||||
|
||||
resp = client.post(
|
||||
f"/api/v1/tests/{test.id}/assign",
|
||||
json={"red_tech_assignee": str(blue_tech_user.id)},
|
||||
headers=red_lead_headers,
|
||||
)
|
||||
assert resp.status_code == 400
|
||||
|
||||
|
||||
def test_red_tech_cannot_assign(client, db, red_tech_headers, red_tech_user):
|
||||
technique = _seed_technique(db)
|
||||
test = _seed_test(db, technique, red_tech_user.id)
|
||||
|
||||
resp = client.post(
|
||||
f"/api/v1/tests/{test.id}/assign",
|
||||
json={"red_tech_assignee": str(red_tech_user.id)},
|
||||
headers=red_tech_headers,
|
||||
)
|
||||
assert resp.status_code == 403
|
||||
|
||||
|
||||
def test_clearing_assignee_does_not_touch_jira(client, db, red_lead_headers, red_lead_user, red_tech_user):
|
||||
"""Sending null explicitly clears the assignee without a Jira sync call."""
|
||||
technique = _seed_technique(db)
|
||||
test = _seed_test(db, technique, red_lead_user.id)
|
||||
test.red_tech_assignee = red_tech_user.id
|
||||
db.commit()
|
||||
|
||||
with patch("app.services.jira_service.push_assignee_update") as mock_push:
|
||||
resp = client.post(
|
||||
f"/api/v1/tests/{test.id}/assign",
|
||||
json={"red_tech_assignee": None},
|
||||
headers=red_lead_headers,
|
||||
)
|
||||
assert resp.status_code == 200
|
||||
assert resp.json()["red_tech_assignee"] is None
|
||||
mock_push.assert_not_called()
|
||||
|
||||
|
||||
def test_assigning_operator_syncs_to_jira(client, db, red_lead_headers, red_lead_user, red_tech_user):
|
||||
technique = _seed_technique(db)
|
||||
test = _seed_test(db, technique, red_lead_user.id)
|
||||
|
||||
# Capture IDs *during* the call, while the endpoint's request-scoped
|
||||
# session is still open — reading them afterward hits a
|
||||
# DetachedInstanceError once that session closes.
|
||||
captured = {}
|
||||
|
||||
def _capture(_db, test_arg, assignee_arg):
|
||||
captured["test_id"] = test_arg.id
|
||||
captured["assignee_id"] = assignee_arg.id
|
||||
|
||||
with patch("app.services.jira_service.push_assignee_update", side_effect=_capture) as mock_push:
|
||||
resp = client.post(
|
||||
f"/api/v1/tests/{test.id}/assign",
|
||||
json={"red_tech_assignee": str(red_tech_user.id)},
|
||||
headers=red_lead_headers,
|
||||
)
|
||||
|
||||
assert resp.status_code == 200
|
||||
mock_push.assert_called_once()
|
||||
assert captured["test_id"] == test.id
|
||||
assert captured["assignee_id"] == red_tech_user.id
|
||||
Reference in New Issue
Block a user